Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] use frontend-web for web client service name #628

Merged
merged 3 commits into from
Dec 12, 2022
Merged

[frontend] use frontend-web for web client service name #628

merged 3 commits into from
Dec 12, 2022

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Dec 11, 2022

Uses frontend-web as the service name for all requests from the web/browser.

This makes it much easier to find browser-based requests vs load generator ones. May also help with service maps for some vendors.

  • CHANGELOG.md updated to document new feature additions

Screen Shot 2022-12-10 at 10 46 49 PM

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team December 11, 2022 03:55
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@austinlparker austinlparker merged commit a5668ad into open-telemetry:main Dec 12, 2022
@puckpuck puckpuck deleted the frontend.web_service_name branch December 13, 2022 18:52
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
…ry#628)

* use frontend-web for web client service name

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

* use frontend-web for web client service name

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Co-authored-by: Austin Parker <austin@ap2.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants